Repository navigation
Tests: split test_numeric_lu per element type (CI critical path) - #93
Merged
Merged
Conversation
…port test_numeric_lu ran unsplit in one worker for 2511 s on the CPU CI job of #85, twice the longest other part (1241 s), and set the 42-min wall time. Every testset in it loops over ELTYPES, so it joins SPLIT_FILES as is. TASKS.md: the T19 follow-up on perm_row of a uniform batch now cites its found-by-agent issue #92. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AvwMxoGmJm3eSmpzxAy72A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: none. This is a follow-up to the non-blocking review nits on #85 (T19).
What was built:
test/runtests.jl:test_numeric_lujoinsSPLIT_FILES. Every testset in it already loops overELTYPES, so noRUN_SHAREDguards are needed. On the CPU CI job of T19: general LU ("G"): reference, device kernels in regimes A/B/C, LU solves with A/Aᵀ/Aᴴ, lu/lu!, report #85 it ran unsplit in a single worker for 2511 s. The longest of all other parts took 1241 s, so this file alone set the 42-minute wall time.TASKS.md: the T19 follow-up aboutperm_rowon a uniform batch now cites perm_row of a uniform LU batch reports batch member 1 only #92, the newfound-by-agentissue for the other nit.Tests:
SDS_TEST_ONLY=test_numeric_lu PTR_NUM_JOBS=4 julia --project=. -e 'using Pkg; Pkg.test()'(Julia 1.13.1, KA CPU backend): 1816 pass / 0 fail / 0 broken, which matches the T19 report. Per-part times on 4 workers: Float32 222 s, Float64 222 s, ComplexF64 307 s, ComplexF32 320 s. CUDA: pending CI.Deviations from PLAN.md / TASKS.md: none.
Follow-up issues opened: #92. Note: as an untriaged
found-by-agentissue it holds the task chain until it is labelledtriagedor closed.🤖 Generated with Claude Code
https://claude.ai/code/session_01AvwMxoGmJm3eSmpzxAy72A
Generated by Claude Code