fix: use nytimes.com in test_find_similar_live for reliability#166
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
fix: use nytimes.com in test_find_similar_live for reliability#166devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: ishan@exa.ai <ishan@exa.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes flaky
test_find_similar_livetest by changing the test URL fromexample.comtonytimes.com. Theexample.comURL was intermittently returning empty results, causing CI failures.Review & Testing Checklist for Human
nytimes.comis a stable choice forfind_similar- I tested 3x locally and it passed each time, but you may want to confirm this is a good long-term choiceTest plan:
Notes
This was identified while investigating CI failures on other PRs in this session.
Link to Devin run: https://app.devin.ai/sessions/59d6881aa8214f7ca6d19c07fcd7ad05
Requested by: ishan@exa.ai