Open
Conversation
Ebay API get category
James-Cheaper
approved these changes
May 5, 2025
James-Cheaper
requested review from
AbhiDoshi2000,
Harsha072,
Urbanmisfit90 and
gmanhas12
webscraper/main.py
Outdated
Collaborator
There was a problem hiding this comment.
Issue: The line results = CheaperScraper.scraper.scrape(pages) incorrectly attempts to access scraper as a class variable.
Suggestion: results = scraper.scrape(pages) already correctly invokes the instance method.
| class UserAccount(models.Model): | ||
| email = models.EmailField(max_length=50, unique=True) | ||
| password = models.CharField(max_length=100) | ||
| password_hash = models.CharField(max_length=100, default='defaultpass123') # added default |
Collaborator
There was a problem hiding this comment.
Concern: Using a default plaintext password ('defaultpass123') is insecure.
Suggestion: Avoid setting a default password, especially one that’s hardcoded and predictable. If necessary for testing, override it in fixtures or during test setup instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ORM models for User and Product with local DB