Chore/ap 5802 remove events#198
Merged
Merged
Conversation
Eliminates eventBeacon creation, event transmission to /events endpoint, confirmation/contamination event sending, and related v1 events tests. Events now only set on context. [AP-5802]
it's the only way to send data back to the server. remove the option and assume it's true in all locations it was used [AP-5802]
DT-1236
reviewed
Jul 3, 2025
Comment on lines
-56
to
-57
| const contextBeacon = options.analytics ? new Beacon(options.endpoint + '/' + options.environment + '/data', context, beaconOptions) : null; | ||
| const eventBeacon = options.beacon || new Beacon(options.endpoint + '/' + options.environment + '/events', context, beaconOptions); |
Contributor
There was a problem hiding this comment.
Was the idea that event beacon would be used if analytics was turned off, but now we only use analytics so it'll always be made?
Contributor
Author
There was a problem hiding this comment.
contextBeacon came in after eventBeacon. eventBeacon gave all the info for visitor based tests. Session based were new and were set to be optional. Now all tests are session based
DT-1236
reviewed
Jul 3, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.