Bind std_tests when a MeanStdMetric has no mean_tests - #1926
Open
darkdi wants to merge 1 commit into
Open
Conversation
get_bound_tests checked mean_tests twice, so a metric given only std_tests fell back to the default tests and dropped the user's ones. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RLUWMiUYbYkPzoYwn1P8uE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed while reading MeanStdMetric: with
MeanError(std_tests=[lte(0.0001)])and no reference data the report comes back with no tests at all, the std test just disappears. Onlymean_testsalone worked. I added a small test for both cases; it fails on main without the one-word change.🤖 Generated with Claude Code
https://claude.ai/code/session_01RLUWMiUYbYkPzoYwn1P8uE