fix: raise ValueError on empty series in divergence stattests - #1924
Open
nisaral wants to merge 1 commit into
Open
fix: raise ValueError on empty series in divergence stattests#1924nisaral wants to merge 1 commit into
nisaral wants to merge 1 commit into
Conversation
Empty reference/current data used to ZeroDivisionError, crash in min(), or return (nan, False) from Hellinger. Guard get_binned_data and Hellinger; keep zero-bin fill math unchanged. Fixes evidentlyai#1900
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1900
Empty reference or current data used to:
ZeroDivisionErrorin PSI / KL / Jensen-ShannonValueError: min() iterable argument is emptywhen both series are empty(nan, False)from HellingerThis raises a single
ValueErrorwith the series sizes. Zero-bin fill math is unchanged.Also checks that PSI stays finite when current values sit outside the reference range.