fix(interpreter): preserve stdout from if/elif condition commands#905
Merged
fix(interpreter): preserve stdout from if/elif condition commands#905
Conversation
execute_if only used condition_result.exit_code, discarding stdout/stderr. Patterns like `if echo "hello"; then ...` or `if ! cmd | jq; then ...` lost the condition's output. Now condition output is prepended to the branch result.
chaliy
force-pushed
the
fix/if-condition-stdout
branch
from
52aa6eb to
30ae7e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
execute_ifonly usedcondition_result.exit_code, discarding stdout/stderrif echo "hello"; then ...orif ! cmd | jq; then ...lost the condition's outputTest plan
cargo test --all-featurespassescargo clippyandcargo fmtclean