fix(interpreter): get_ifs_separator respects local IFS#902
Merged
Conversation
get_ifs_separator() only checked self.variables for IFS, missing
local IFS declarations stored in call_stack.locals. This caused
local IFS=":" to have no effect on "${arr[*]}" array joining.
Fix: use expand_variable("IFS") which checks locals first.
chaliy
force-pushed
the
fix/ifs-local-scoping
branch
from
1638f9a to
045f988
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_ifs_separator()only checkedself.variablesfor IFS, missing local IFS declarations stored incall_stack.locals. This causedlocal IFS=":"to have no effect on"${arr[*]}"array joining inside functions.expand_variable("IFS")which checks locals first, with proper handling of unset vs empty IFS.Test plan
cargo test --all-features -p bashkit --lib— all 2123 tests passcargo clippy --all-targets --all-features -- -D warnings— cleancargo fmt --check— cleantest_local_ifs_array_joincovers the exact bug