fix(builtins): read builtin respects local variable scoping#901
Merged
Conversation
The read builtin wrote directly to the global variables map (ctx.variables), bypassing function-local scoping. When local k was declared, read -r k wrote to global scope while local shadowed it. Fix: read now returns SetVariable side effects applied through set_variable() which checks call_stack.locals first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
readbuiltin wrote directly to the global variables map (ctx.variables), bypassing function-local scoping. Whenlocal kwas declared,read -r kwrote to global scope while the local shadowed it, resulting in empty values.readnow returnsSetVariableside effects (likeread -aalready returnsSetArray), applied by the interpreter throughset_variable()which checkscall_stack.localsfirst.Test plan
cargo test --all-features -p bashkit --lib— all 2123 tests passcargo clippy --all-targets --all-features -- -D warnings— cleancargo fmt --check— cleantest_read_respects_local_scopecovers the exact bug