fix(interpreter): initialize assoc/indexed arrays for local -A/-a#886
Open
fix(interpreter): initialize assoc/indexed arrays for local -A/-a#886
Conversation
…hout value `local -A m` followed by `m["a"]="1"` produced an indexed array instead of associative because execute_local_builtin only inserted into call_stack.locals without creating the assoc_arrays entry. Initialize the appropriate array type when local -A or -a is used without a compound assignment value, in both function and global paths. Closes #875
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
local -A mfollowed bym["a"]="1"produced an indexed array instead of associative, becauseexecute_local_builtinonly inserted intocall_stack.localswithout creating theassoc_arraysentrylocal -Aor-ais used without a compound assignment valueassoc_local_declare_then_assignandassoc_local_keys_in_cmdsubTest plan
cargo test --all-featurespassescargo fmt --checkandcargo clippycleanCloses #875