fix(interpreter): check errexit_suppressed in execute_script_body#884
Open
fix(interpreter): check errexit_suppressed in execute_script_body#884
Conversation
set -e incorrectly exited when a for/while/until loop body ended with an AND-OR chain (e.g. [[ test ]] && cmd) that returned non-zero. Check result.errexit_suppressed in execute_script_body to suppress errexit for compound commands whose non-zero exit came from && or ||. Closes #873
chaliy
force-pushed
the
fix/issue-873-errexit-and-or-chain
branch
from
4039d7a to
97078b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set -eincorrectly exited when a for/while/until loop body ended with[[ test ]] && cmdreturning non-zeroresult.errexit_suppressedinexecute_script_bodyfor both errexit and ERR trap suppressionset_e_and_chain_at_end_of_for_bodyreproducing the exact issue scenarioTest plan
set_e_and_chain_at_end_of_for_bodypassescargo test --all-featurespassescargo fmt --checkandcargo clippycleanCloses #873