Redesign landing page for senior engineering#86
Merged
Conversation
Improve mobile experience with better scroll handling, refined spacing, and responsive design: - Add overflow-x:hidden to prevent unwanted horizontal scroll - Implement scrollable mobile menu with max-height constraints and momentum scrolling - Adjust container padding: 1.5rem → 1.25rem on mobile with breakpoint-specific scaling - Make team grid fully responsive (minmax → 1fr) - Enhance contact button with better touch targets and font styling - Update acceptance test threshold from 0.03 to 0.045 for stricter visual consistency - Add qa-runner agent for mechanical quality gate automation
ppmarkek
marked this pull request as ready for review
July 23, 2026 06:05
ilyar
approved these changes
Jul 23, 2026
ilyar
left a comment
ilyar
left a comment
Contributor
There was a problem hiding this comment.
Провёл полный review текущего head 7c43fc1. Блокирующих или критичных замечаний не обнаружил.
Что проверено:
- весь diff редизайна, включая hero, navbar/mobile menu, team, services/technology marquee, contact, footer, design tokens, cache-reset path и обновлённые acceptance/visual tests;
- существующие reviews, top-level comments и inline threads: замечаний и unresolved threads в PR нет, поэтому неподтверждённых старых требований не осталось;
- GitHub checks: QA и CodeQL полностью зелёные;
- локально на чистом worktree:
npm run lint, production build,npm run acceptance:test(37 passed, 1 ожидаемо skipped; 20 visual baselines),npm run lighthouse; - Lighthouse для главной: 1.00 performance, accessibility, best practices и SEO;
- ручной browser pass на desktop и mobile: рендер секций, hash-навигация, мобильное меню и Escape/focus return, отсутствие горизонтального overflow, lazy-load портретов, внешние CTA/социальные ссылки, reduced-motion поведение marquee, отсутствие console errors/warnings.
Почему считаю изменения готовыми: новый UI сохраняет обязательные продуктовые и контактные пути, остаётся читаемым и адаптивным, не вносит runtime-зависимых уязвимостей (npm audit --omit=dev — 0), а motion корректно отключается для prefers-reduced-motion. Остаточный риск обычный для крупного визуального изменения и покрыт актуализированными screenshot baselines плюс ручной проверкой двух основных viewport-классов.
Approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The previous direction felt visually noisy and less credible for a senior engineering practice. This update makes the site clearer, faster to render, and more consistent across desktop and mobile.
Validation
npm run lintnpm run acceptance:testnpm run lighthouse