fix(vtl_adapter): fix operation mode subscription#65
Merged
Conversation
Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>
…test.py Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>
Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>
Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>
…ndency Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>
Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>
Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
description
this change is that how the operation mode state is handled and propagated within the VTL adapter, centralizing its subscription and sharing the latest state across all interface converters. This eliminates redundant subscriptions and simplifies the interface for converter classes, ensuring all converters have consistent and up-to-date access to the operation mode state.
And test_tools call to
window.refresh()is removed from the test script, likely as a cleanup or to prevent unnecessary UI updates.related link
https://tier4.atlassian.net/browse/AEAP-3326
test
Confirm that it can pass through the VTL line after setting ID,GPIO:and period.