first commit - #1
Open
evalx95-spec wants to merge 2 commits into
Open
Conversation
k-asadova
reviewed
Apr 13, 2026
| def __init__(self): | ||
| self.points = 0 | ||
|
|
||
| def get_points_for_place(self, place): |
There was a problem hiding this comment.
get_points_for_place и get_points_for_meters лучше сделать статичными
| def get_points_for_place(self, place): | ||
| if place > 100: | ||
| print('Баллы начисляются только первым 100 участникам') | ||
| return self.points |
There was a problem hiding this comment.
здесь переменная points должна быть локальной, а не перезаписываться как атрибут.
иначе сейчас возможна такая ситуация:
tp = TotalPoints()
tp.get_points_for_place(150) # Ошибка, возвращает self.points (0)
tp.get_points_for_place(10) # Возвращает 91
tp.get_points_for_place(200) # Ошибка, возвращает 91 (а должно быть 0!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.