ci: ignore unknown features#3
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions CI workflow to make cargo-hack feature-powerset runs resilient when some crates don’t define all features by ignoring unknown features, reducing avoidable CI failures while keeping broad feature coverage.
Changes:
- Add
--ignore-unknown-featurestocargo hack clippy --feature-powersetinvocation. - Add
--ignore-unknown-featurestocargo hack nextest run --feature-powersetinvocation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the CI workflow configuration to improve compatibility when running checks with multiple feature combinations. The main change is the addition of the
--ignore-unknown-featuresflag to both the clippy and nextest steps, which helps prevent failures caused by unknown features in the workspace.CI workflow improvements:
--ignore-unknown-featuresto thecargo hack clippystep in.github/workflows/ci.ymlto avoid errors from unknown features when linting.--ignore-unknown-featuresto thecargo hack nextest runstep in.github/workflows/ci.ymlto ensure tests don't fail due to unknown features.