Repository navigation
Bump xatu-sidecar to v0.0.7 and forward Gloas gossip events - #12
Merged
Merged
Conversation
Execution payload envelopes, execution payload bids, payload attestation messages, proposer preferences and Gloas data column sidecars accepted on gossip are now sent to xatu-sidecar with the v0.0.7 event types.
There was a problem hiding this comment.
Bumps xatu-sidecar to v0.0.7 and adds five Gloas gossip event branches to the xatu plugin. All referenced teku master classes/getters exist, the instanceof ordering is correct (Gloas sidecar implements the base interface), the Gloas gossip topics in teku deserialize into exactly these types, and every event_type name and JSON field matches xatu-sidecar v0.0.7's Raw* structs. No known vulnerabilities. Clean.
Reviewed 4 changed file(s) @ 00214314 — no blocking issues found.
"First, solve the problem. Then, write the code." — John Johnson
Self-built execution payload envelopes carry builder_index UINT64_MAX, which longValue() turned into -1 and xatu-sidecar rejected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps xatu-sidecar to v0.0.7 in the apply script and in the Docker build patch. The xatu plugin now sends Gloas gossip messages to the sidecar as the new v0.0.7 event types: execution payload envelopes, execution payload bids, payload attestation messages, proposer preferences and Gloas data column sidecars. Pre-Gloas events are unchanged.