fix(http): reroute SingleAttestation payloads on the attestation topic#26
Open
samcm wants to merge 2 commits into
Open
fix(http): reroute SingleAttestation payloads on the attestation topic#26samcm wants to merge 2 commits into
samcm wants to merge 2 commits into
Conversation
Grandine (post-Electra) emits SingleAttestation objects on the "attestation" SSE topic instead of "single_attestation", causing a constant stream of "Failed to parse attestation: aggregation bits missing" errors and lost events. Detect the SingleAttestation shape on parse failure and dispatch through the single_attestation handler so the event still reaches consumers and the error spam stops.
Note that SingleAttestation is an EIP-7549 (Electra) construct, so the probe never matches pre-Electra payloads — they always carry aggregation_bits and go through the normal VersionedAttestation path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grandine post-Electra emits
SingleAttestationJSON on theattestationSSE topic (instead ofsingle_attestation), which triggers a constant stream ofFailed to parse attestation: aggregation bits missingerrors at xatu-sentry and drops every event. This change detects the SingleAttestation shape on parse failure and dispatches via the existinghandleSingleAttestationEvent, so consumers keep getting the events and the error spam stops.isSingleAttestationPayloadprobes forattester_indexin the JSON.attestation-topic parse failure with that shape, we rewritemsg.Eventtosingle_attestationand call the existing single-attestation handler so both typed (SingleAttestationHandler) and generic (Handler) consumers route correctly.