Repository navigation
fix(deps): update dependencies with Dependabot security alerts - #352
Conversation
Go: - Upgrade the vulnerable modules to their patched versions: podman, buildah, runc, grpc, x/crypto, x/net, otel, pgx, fulcio, go-jose, go-ethereum, gnark-crypto, aws-sdk-go-v2 s3 and moby/sys/user. - fulcio v1.8.6 needs Go 1.25.7 or later. Set the go directive to 1.25.7. Use Go 1.26 in CI and in the Dockerfile. - Upgrade golangci-lint to v2.14.0 because v2.3.0 cannot lint Go 1.25 code. Pin the install script to the release tag. The script on master fails its checksum check on the new .sbom.json assets. UI: - Upgrade vitest to v4, echarts to 6.1 and @scalar/api-reference-react to 0.9. - Add an override for @ai-sdk/provider-utils, because scalar pins a vulnerable version. - Run npm audit fix for the transitive packages. npm audit now reports 0 vulnerabilities.
There was a problem hiding this comment.
Summary
This PR bumps Go and npm dependencies to clear Dependabot alerts, and also moves CI/Dockerfile to Go 1.26 plus golangci-lint v2.14.0. The UI changes (vitest 4, echarts 6.1, Scalar 0.9, provider-utils override, npm audit fix) are clean, but five of the bumped Go modules are pinned to versions OSV still flags with fixed releases already available, so the security goal is only partly met. podman/buildah/docker/docker advisories have no patched version and remain, as the PR notes.
Issues
- 🔴
go.mod:198— grpc pinned to a version OSV still flags — OSV reports GO-2026-6443 / GHSA-2v4p-qf9q-27wj (server panic via missing:authority/Hostheaders) affectingv1.83.1; it is fixed inv1.83.2, which is already available on the proxy. The bump from 1.77.0 leaves a fixable advisory in place. - 🔴
go.mod:193— x/net still vulnerable to fixable HTTP/2 advisories — see the thread on that line - 🔴
go.mod:29— x/crypto still vulnerable to fixable advisories — see the thread on that line - 🔴
go.mod:112— klauspost/compress pinned to a version with an OOB read — see the thread on that line - 🔴
go.mod:195— x/text pinned to a version with a parsing panic — OSV reports GO-2026-6629 (panic parsing crafted input ingolang.org/x/text/secure/precis) affectingv0.40.0, fixed inv0.41.0, which is available.
Reviewed @ 58171d3a
"If you can't measure it, you can't improve it." — Peter Drucker
- Upgrade grpc to v1.83.2, x/crypto to v0.57.0, x/net to v0.60.0, x/text to v0.42.0, klauspost/compress to v1.18.7 and go-chi/chi to v5.3.0. - x/net v0.60.0 needs Go 1.26.0, so set the go directive to 1.26.0. - Set the toolchain to go1.26.9. This version has the fixes for the standard library advisories.
SummaryDependency-bump PR fixing the open Dependabot alerts: Go modules upgraded (podman 5.8.6, buildah 1.43.2, runc 1.3.6, grpc 1.83.2, x/crypto 0.57.0, x/net 0.60.0, otel 1.45.0, pgx 5.9.2, go-ethereum 1.17.0, gnark-crypto 0.18.1, modernc sqlite stack, etc.) with Go/toolchain moved to 1.26, CI and Dockerfile aligned, golangci-lint pinned to v2.14.0; UI bumps vitest to 4, echarts 6.1, scalar 0.9 with an override for @ai-sdk/provider-utils. I batch-queried OSV for all 199 Go modules and all 566 lockfile packages: the UI tree is fully clean and every module the PR set out to fix is clean at the new versions. The three open findings from the last review (x/net, x/crypto, klauspost/compress) are all resolved. Remaining OSV hits are docker/docker (unchanged from master, no patched version on the module path, explicitly deferred) and unfixable podman/buildah advisories that affected master's versions equally. Issues
Reviewed @ |
This PR fixes the open Dependabot alerts in
go.modandui/package-lock.json. It also fixes all the fixable findings thatgovulncheckreports.Go
1.26.0, and the toolchain isgo1.26.9, which has the fixes for the standard library advisories. CI and the Dockerfile use Go 1.26.masterfails its checksum check, because its grep also matches the new.sbom.jsonassets.UI
@vitest/mockeralerts), echarts to 6.1 and@scalar/api-reference-reactto 0.9.overridesentry for@ai-sdk/provider-utils. Scalar pins a vulnerable 4.0.5 version throughai.npm audit fixfor the transitive packages.npm auditnow reports 0 vulnerabilities.Not fixed
These advisories have no fixed version:
github.com/docker/docker: The fix is a move to thegithub.com/moby/mobymodules. That is a code change, so a separate PR must do it.golang.org/x/cryptoGO-2026-5932,containers/buildahGO-2026-5116,containers/podman/v5GO-2025-3961 and GO-2024-3042.Tests
go buildandgo vetpass, including aCGO_ENABLED=0 GOOS=linuxbuild.govulncheckreports only the advisories without a fix.golangci-lintv2.14.0 with--new-from-rev=origin/masterreports 0 issues.go test ./...passes on macOS, exceptTestBuildManifestExcludesandTestValidateDataDirMethods_SchelkBinary. Both also fail onmasteron macOS: one because of the/privatetmpdir symlink, and one because macOS has no/proc/mounts.npm run buildandnpm test(73 tests) pass.npm run lintshows the same 2 warnings as onmaster.