feat: max tx cost limit for redistribution game#5473
Draft
sbackend123 wants to merge 7 commits into
Draft
Conversation
# Conflicts: # cmd/bee/cmd/cmd.go # cmd/bee/cmd/start.go # pkg/node/node.go # pkg/storageincentives/redistribution/redistribution.go # pkg/transaction/mock/transaction.go # pkg/transaction/transaction.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Added an option to configure retry delay and max_tx_cost for retry transactions.
For the redistribution game, this enables:
minEstimatedGasLimitwas halved; gas price is no longer taken from context for redistribution game transactions.Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
A long retry delay can leave the user unable to resend the transaction before the redistribution game phase ends, which means losing the right to participate in that round. For that reason, the delay is shortened for commit, reveal, and claim transactions.
A claim transaction is also roughly 1.5× more expensive than commit and reveal. With a user-configured max tx cost, funds may already be spent on commit and reveal while claim never goes through because of the limit — leaving the user at a net loss. To avoid that, the node is allowed to ignore the configured limit.
Related Issue (Optional)
#5142
Screenshots (if appropriate):
AI Disclosure