Add Vision-based Image OCR converter, docs, and tests - #9
Merged
etherlink-intern merged 1 commit intoJun 2, 2026
Merged
etherlink-intern merged 1 commit into
etherlink-intern merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
unsupportedFormatby default.Description
ImageOCRConverterwhich uses conditional imports forVision,CoreGraphics, andImageIOto run text recognition and return aMarkdownDocument, and otherwise throwsConversionError.unsupportedFormat.DocumentFormatwith image kinds (png,jpeg,heic,tiff,gif), addimageFormatsset, and map common content-types and extensions.ImageOCRConverterinMarkItDown.defaultConvertersso images are handled by the pipeline when supported.Docs/ImportButtonIntegration.mdwith SwiftUIfileImporter/PhotosPickerexamples and updateREADME.md; expand tests inSwiftMarkItDownTeststo cover image format inference and conditional OCR rendering tests.Testing
swift test, which executedSwiftMarkItDownTests(including conditional OCR tests) and completed successfully.Vision/CoreGraphics/ImageIO, and they assert the expectedunsupportedFormatbehavior when those frameworks are unavailable.Scripts/smoke-test.shto ensure basic CLI scenarios remain unchanged and they passed.Codex Task