Add iOS demo app, CI, smoke tests, fixtures, and HTML converter cleanup - #6
Merged
Merged
Conversation
etherlink-intern
marked this pull request as ready for review
May 31, 2026 18:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
SwiftMarkItDownpackage and make CI validate the package plus the demo.Description
App/SwiftMarkItDownApp/withContentView.swiftandSwiftMarkItDownApp.swiftplus an Xcode project and scheme to build the demo./.github/workflows/ci.ymlthat runsswift test, the CLI smoke script, and anxcodebuildof the iOS demo on macOS runners.Scripts/smoke-test.shand test fixtures inTests/Fixtures/with expected outputs inTests/Expected/and wired the smoke tests into CI.Sources/SwiftMarkItDown/Converters/HTMLConverter.swiftto strip<head>sections and trim per-line whitespace to avoid leaking titles/styles/scripts into Markdown.README.mdto reflect the demo app, new smoke tests, and the adjusted HTML handling.Testing
swift testand the core conversion tests inTests/SwiftMarkItDownTests, which succeeded.Scripts/smoke-test.shagainst fixtures inTests/Fixtures/, which succeeded.xcodebuildusing theSwiftMarkItDownAppscheme for a simulator destination, which completed successfully.Codex Task