Add CI, smoke tests, fixtures, and improve HTML conversion handling - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
mainto prevent regressions.<head>and normalize whitespace so output is more predictable.Description
/.github/workflows/ci.ymlto runswift testandScripts/smoke-test.shon pull requests, pushes tomain, and manual dispatch.Scripts/smoke-test.shwhich builds theswift-markitdownproduct and compares CLI output for fixtures with files inTests/Expectedusingdiff.Tests/Fixtures/and matching expected Markdown files underTests/Expected/, and updateTests/SwiftMarkItDownTests/SwiftMarkItDownTests.swiftto exercise those cases.Sources/SwiftMarkItDown/Converters/HTMLConverter.swiftto strip the<head>block, trim per-line whitespace, collapse extra blank lines, and preserve HTML entity decoding.Testing
swift testand the core unit test suite inSwiftMarkItDownTests, and all tests passed.Scripts/smoke-test.shwhich built the CLI and validatednote.txt,page.html,table.csv, anddata.jsonagainst expected outputs, and all smoke-test cases passed.swift testandScripts/smoke-test.shchecks on GitHub Actions.Codex Task