Add PDFKit-backed PDF converter, update docs, tests, and CI matrix - #17
Merged
etherlink-intern merged 1 commit intoJun 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PDFKitis available.PDFKitavailability.Description
PDFConverter(compiled behind#if canImport(PDFKit)) that extracts embedded page text, returns Markdown, and emitspageCountandextractedTextPageCountmetadata.PDFConverterinMarkItDown.defaultConvertersso PDFs are handled by the default pipeline.Tests/Fixtures/sample.pdf,Tests/Fixtures/empty.pdf) and an expected output (Tests/Expected/sample.md) and extend tests to conditionally exercise PDF conversion whenPDFKitis available.Scripts/smoke-test.shto run or expect PDF behavior based onPDFKitavailability, update documentation inREADME.mdandDocs/NativeConverterBackends.md, and expand the GitHub Actions workflow to a matrix withmacos-15andubuntu-latest.Testing
swift teston macOS wherePDFKitis available and the PDF tests were exercised and passed.Scripts/smoke-test.shon macOS (PDF cases exercised) and on Ubuntu (PDF cases asserted as unsupported), and the smoke tests passed.swift testandScripts/smoke-test.shchecks across the new OS matrix via the updated workflow.Codex Task