Fix duplicate OCR test declarations in tests - #15
Closed
etherlink-intern wants to merge 1 commit into
Closed
etherlink-intern wants to merge 1 commit into
etherlink-intern wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
swift teston CI.Description
Tests/SwiftMarkItDownTests/SwiftMarkItDownTests.swiftso the test is declared only once.OCRSample,renderedOCRSamples,renderOCRImage) and left a single helper implementation behind a balanced#if ... #endifguard.#else/#endifand macro redeclaration errors during test macro expansion.Testing
swift testand all tests passed (10 tests executed and passed).Scripts/smoke-test.shand it completed successfully.Codex Task