chore: Remove L2CM and CANNON_KONA Dev Feature Flags#21591
Draft
0xCoati wants to merge 9 commits into
Draft
Conversation
Conflicts: - ./packages/contracts-bedrock/snapshots/semver-lock.json
L2CM and CANNON_KONA Dev Feature Flags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the L2CM and CannonKona dev feature flags, making both the default codepath.
L2CM:
DevFeatures.sol) and Go (devfeatures.go) definitions.ConditionalDeployerandL2DevFeatureFlagspredeploys unconditional in thePredeploysregistry.CannonKona:
0x10retired).startingRespectedGameTypeoverride gate inOPContractsManagerV2._isPermittedInstruction— to the always-on path (behavior-neutral, the shim already forced it totrue).DEV_FEATURE__CANNON_KONAenv plumbing (Config.sol,FeatureFlags.sol), the*AlwaysEnabled*override tests, fuzz-test exclusions, and the commented-out CI matrix entry.OPContractsManagerV27.1.23→7.1.24; regeneratessemver-lock.jsonand the NUT bundle snapshot.Note: on-chain
L2DevFeatureFlags.isDevFeatureEnabled(0x10)now reports the actual bitmap instead of always-true — same precedent as the retired L2CM bit; nothing on-chain consumes it.Notes
Addresses both flag removals from #20084 . The removal of the entire dev features system should be tracked in a separate issue.