Skip to content

fix: backward-compat for ESM etherpad #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamTV12345 merged 1 commit into from
May 25, 2026
Merged

fix: backward-compat for ESM etherpad #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const settingsModule = require('ep_etherpad-lite/node/utils/Settings');
const settings = settingsModule.default || settingsModule;
const {template, rawHTML} = require('ep_plugin_helpers');
const eejs = require('ep_etherpad-lite/node/eejs/');
const eejs = require('ep_etherpad-lite/node/eejs');
Copy link
Copy Markdown

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. No regression test for eejs require 📘 Rule violation ☼ Reliability

This PR changes module resolution behavior in index.js (bug fix) but does not add or update any
automated test that would fail before the change and pass after. This increases the risk of the ESM
compatibility issue being reintroduced without detection.
Agent Prompt 
## Issue description
A bug fix was made to remove the trailing slash from `require('ep_etherpad-lite/node/eejs')`, but there is no accompanying regression test to prevent the issue from coming back.

## Issue Context
The change is intended to be backward-compatible and to avoid failures under Node's strict ESM exports map resolution. Compliance requires adding or updating an automated test in the same commit that would fail before this change and pass after.

## Fix Focus Areas
- index.js[6-6]
- static/tests/backend/specs/esm_compat.spec.ts[1-120]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

const shared = require('./static/js/shared');

exports.eejsBlock_editbarMenuLeft = template('ep_font_size/templates/editbarButtons.ejs', {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"description": "Apply sizes to fonts",
"name": "ep_font_size",
"version": "0.4.110",
"version": "0.4.111",
"license": "Apache-2.0",
"author": {
"name": "John McLear",
Expand Down
Loading