Allow downloading non-default taxdump file for NCBITaxa - #814
Open
KatSteinke wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when initializing
NCBITaxawith a non-defaulttaxdump_file, ete4 will not download the taxdump to that location if it doesn't already exist, leading to an error. This breaks using ete4 for taxonomy handling in a Snakemake pipelin on a cluster for me.In order to allow downloading a taxdump to a non-default location, I've changed the logic in
update_dbso it will always runupdate_local_taxdump(can change that to only update if it doesn't exist if there's a use case for having a "frozen" taxdump that you download once and never touch?). I've also added a test for that (not run by default, as it downloads the files it's one of the slow tests).(Have also tweaked the expected output of getting species-level descendant taxa for Pan, as there now is a third species-level descendant taxon Pan sp..)