Skip to content

Fix italic markdown detection at line start #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshTheWanderer merged 2 commits into from
Jan 23, 2026
Merged

Fix italic markdown detection at line start #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e40be1
fix: allow italic and bold at the start of a message
JoshTheWanderer Jan 23, 2026
57d2946
test: add test for multi-line italic rendering
JoshTheWanderer Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/helpers/content_filters/markdown_filter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class ContentFilters::MarkdownFilter < ActionText::Content::Filter
# 2. Use backslash escaping: \*\*not bold\*\* → renders as **not bold** (plain text)
MARKDOWN_PATTERNS = [
/\*\*[^*]+\*\*/, # Bold: **text**
/(?<!^)\*[^*\s][^*]*\*/m, # Italic: *text* (not at line start to avoid "* list items")
/(?<!\*)\*(?![*\s])[^*]+\*(?!\*)/, # Italic: *text* (lookarounds avoid **bold** and "* list items")
/`[^`]+`/, # Inline code: `code`
/```[\s\S]+?```/, # Code blocks: ```code```
/^[#]{1,6}\s/m, # Header levels 1-6: # Header
Expand Down
13 changes: 13 additions & 0 deletions test/helpers/content_filters_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,19 @@ class ContentFiltersTest < ActionView::TestCase
assert_markdown_rendered "This is *italic* text", /<em>italic<\/em>/
end

test "renders italic text at line start" do
assert_markdown_applicable "*italic* at start"
assert_markdown_rendered "*italic* at start", /<em>italic<\/em>/
end

test "renders italic text spanning multiple lines" do
multiline_italic = "*italic text\nacross lines*"
assert_markdown_applicable multiline_italic
filtered = apply_text_filters(multiline_italic)
assert_match /<em>italic text/, filtered.to_html
assert_match /across lines<\/em>/, filtered.to_html
end

test "renders inline code with backticks" do
assert_markdown_rendered "Use the `print()` function", /<code>print\(\)<\/code>/
end
Expand Down