Skip to content

fix(nui): reset styled text with ~s~#1783

Open
Gamzky wants to merge 1 commit into
esx-framework:mainfrom
Gamzky:patch-1
Open

fix(nui): reset styled text with ~s~#1783
Gamzky wants to merge 1 commit into
esx-framework:mainfrom
Gamzky:patch-1

Conversation

@Gamzky
Copy link
Copy Markdown

@Gamzky Gamzky commented May 19, 2026

Description

Fix ~s~ so it closes colored text in NUI notifications (it was removed before parsing, so colors never reset).


Motivation

Strings like ~b~$500~s~ should match GTA/ESX markup. They stayed the wrong color because ~s~ was stripped too early.


Implementation Details

Stop stripping ~s~ before the color pass. Strip any leftover ~s~ only after replaceColors runs on title and message.


Usage Example

ESX.ShowNotification('Paid ~b~$500~s~ deposit.', 'info', 5000)

Before:
image

After:
image


PR Checklist

  • My commit messages and PR title follow the Conventional Commits standard.
  • My changes have been tested locally and function as expected.
  • My PR does not introduce any breaking changes.
  • I have provided a clear explanation of what my PR does, including the reasoning behind the changes and any relevant context.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 19, 2026

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants