Repository navigation
Conversation
The SCD4x doesn't send an ACK when waking from sleep mode, which was causing wake_up failures. Implemented the handle invalidation pattern to temporarily disable ACK checking just for this command. - scd4x_wake_up() now uses dynamic ACK control via handle invalidation - bump timeout from 20ms to 30ms (as in discussions) - add explicit disable_ack_check = false in init_desc for clarity - update function docs
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2
The SCD4x doesn't send an ACK when waking from sleep mode, which was causing wake_up failures. The new handle invalidation function added in esp-idf-lib/i2cdev#9 will now allow to temporarily disable ACK checking just for this command.
Changes:
Tested WITHOUT real hardware - feedback appreciated.