Add TAP endpoint and query behavior tests#13
Merged
Conversation
Add comprehensive tests for TAP endpoint selection and ADQL/query behavior. Tests cover: invalid tap_endpoint names, detection of schema prefixes in TAP_CAT table names, ROW_LIMIT validation, _try_retrieve_pyvo_table error messages and overflow handling, selecting the correct TAP endpoint/session for authenticated and unauthenticated calls, propagation of tap_endpoint through query_tap to the retriever, correct metadata queries for columns_table on tap_obs vs tap_cat (including prefix-stripping), list/help flows using the catalog endpoint, and dry-run get_query_payload behavior for both _query_on_allowed_values and query_catalog. Also import eso.core as eso_core to allow monkeypatching TAPService and add missing pytest import in catalog tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comprehensive tests for TAP endpoint selection and ADQL/query behavior. Tests cover: invalid tap_endpoint names, detection of schema prefixes in TAP_CAT table names, ROW_LIMIT validation, _try_retrieve_pyvo_table error messages and overflow handling, selecting the correct TAP endpoint/session for authenticated and unauthenticated calls, propagation of tap_endpoint through query_tap to the retriever, correct metadata queries for columns_table on tap_obs vs tap_cat (including prefix-stripping), list/help flows using the catalog endpoint, and dry-run get_query_payload behavior for both _query_on_allowed_values and query_catalog. Also import eso.core as eso_core to allow monkeypatching TAPService and add missing pytest import in catalog tests.