[nzakas]

Adds shell/no-ls-iteration, which mirrors ShellCheck SC2045: for f in $(ls) breaks on filenames with spaces or glob characters; use a glob instead.

Behavior

• Reports a command substitution in a for ... in word list whose first statement is ls, or a pipeline that starts with ls ($(ls | grep log)). Both $(...) and backticks are checked.
• Not reported: globs, other commands such as $(find ...), and ls outside a for word list. ShellCheck's broader "parsing ls output" check, SC2012, isn't covered.
• No autofix: the right glob depends on the ls flags and arguments.
• Recommended config: "error".

Documentation

Adds docs/rules/no-ls-iteration.md, following the format of the @eslint/json, @eslint/css, and @eslint/markdown rule docs: description, background, rule details with incorrect and correct examples, options, when not to use it, and the ShellCheck reference. The rule's meta.docs.url points at that file, and its README table entry links to it.

Testing

9 RuleTester cases and 5 documentation checks (259 total); build, lint, and format checks pass.

🤖 Generated with Claude Code

---

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Central YAML; Path: .coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 73e49d0c-f764-4619-8f4b-2918fc4f2681

📥 Commits

Reviewing files that changed from the base of the PR and between 01edc8b and 133bc25.

📒 Files selected for processing: 9

• README.md
• docs/rules/no-ls-iteration.md
• src/index.spec.ts
• src/index.ts
• src/rules/no-ls-iteration.spec.ts
• src/rules/no-ls-iteration.ts
• src/rules/no-unquoted-expansions.ts
• src/rules/utils.ts
• tests/plugin.test.ts

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Copilot review overview

🟡 Changes recommended

The recommended autofix interaction can silence the new rule while changing loop behavior.

Review effort: Balanced
Findings: 1 · 1

Open (2)

• Prevent autofix from defeating no-ls-iteration · New
• Correct inaccurate SC2012 rule reference · New

What changed in this PR

Adds the bash/no-ls-iteration rule to detect fragile iteration over ls output.

Changes:

• Implements and tests SC2045-style detection.
• Enables the rule in the recommended configuration.
• Adds rule documentation and README registration.

File	Description
src/​rules/​no-ls-iteration.ts	Implements the rule.
src/​rules/​no-ls-iteration.spec.ts	Adds rule tests.
src/​index.ts	Registers and enables the rule.
src/​index.spec.ts	Verifies rule registration.
README.md	Adds the rule to the catalog.
docs/​rules/​no-ls-iteration.md	Documents behavior and examples.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[nzakas]

@copilot address review comments. Be sure to add tests.

[Copilot]

@copilot address review comments. Be sure to add tests.

Addressed in commit f7c9598: no-unquoted-expansions no longer autofixes ls substitutions in for word lists, added recommended-config integration coverage, and corrected the ShellCheck reference to SC2045.