Add workspace move_file tool for file moves / 新增工作区 move_file 工具处理文件移动#4316
Open
SivanCola wants to merge 5 commits into
Open
Add workspace move_file tool for file moves / 新增工作区 move_file 工具处理文件移动#4316SivanCola wants to merge 5 commits into
SivanCola wants to merge 5 commits into
Conversation
Collaborator
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c3ca2a026e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Collaborator
Author
|
Pushed a follow-up fix for the Windows test failure in Root cause:
What changed:
Verified locally:
|
Collaborator
Author
|
approve |
Collaborator
Author
|
Pushed Root cause:
What changed:
Verified locally:
GitHub Actions update:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4310.
This adds a workspace-confined
move_filebuilt-in for moving or renaming files without going through shell-specific commands such asmvor PowerShellMove-Item.Why
File move/rename tasks could be routed through
bash, where persisted approvals are intentionally scoped by command prefix. Moving several different files can therefore keep prompting even after the user chooses always allow. A dedicated file-mutation tool lets those operations share the existingEditpermission family instead.What changed
move_file(source_path, destination_path)with workspace confinement for both source and destination.move_filein the file-mutation permission family, CLI/ACP/evidence/tool-card classification, token economy core tools, and docs.move_fileinstead of shellmv/Move-Itemfor file moves.Validation
go test ./...go test .indesktopgit diff --checkgo test -cNot run: frontend
npm testbecausenpmis unavailable in the local environment.