Repository navigation
Conversation
The test suite has failed on main since the lock moved to newer packages:
- PyJWT 2.15 rejects trailing characters after the signature, and the test
token loaded from auth_token.txt ends with the file's newline
('Invalid crypto padding'). The tests now strip it.
- aioresponses does not support aiohttp 3.14 yet (ClientResponse needs
stream_writer, pnuckowski/aioresponses#289). A uv constraint keeps the
development lock on aiohttp 3.13 until it does; the published requirement
(aiohttp>=3.0.0) is unchanged.
aioresponses was also listed as a runtime dependency although only the tests
use it, so every install pulled a test mocking library. It now sits in the
dev group.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
@erwindouna The red "Verify" check is the label gate: contributors can't set labels. Suggested: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The test workflow on
mainhas failed since May (last green run 19 May 2026). Two package updates break the suite:tests/fixtures/auth_token.txtends with the file's newline, so the suite ends with 57 errors and 5 failures (Invalid crypto padding). The tests now.strip()the loaded token. The fixture file is unchanged, because the end-of-file hook would add the newline back.stream_writerargument inClientResponse, which aioresponses doesn't pass yet (issue with aiohttp-3.14 pnuckowski/aioresponses#289; fixes open in fix: support aiohttp 3.14 required stream_writer argument pnuckowski/aioresponses#288 and fix: support aiohttp 3.14 pause_reading pnuckowski/aioresponses#292). A[tool.uv] constraint-dependencies = ["aiohttp<3.14"]keeps the development lock on aiohttp 3.13.5 until aioresponses supports 3.14. It only affectsuv.lock; the published requirementaiohttp>=3.0.0is unchanged.uv lockchanged nothing else (only aiohttp 3.14.4 → 3.13.5).aioresponseswas also a runtime dependency, although only the tests use it. Every install of tadoasync pulled a test mocking library. It now sits in thedevgroup;deptry srcreports no issues.Checked locally with the workflow's commands (
uv sync,uv run pytest --cov=tadoasync tests --cov-fail-under=95,ruff check,ruff format --check,mypy src) on Python 3.14: 83 passed, 49 snapshots, coverage 96.5%.Related Issues