Conversation
Add opt-in captures for the main, mhchem and prooftree corpora, comparing complete ASTs, DisplayLists, render results and PNG bytes against a local baseline. Keep committed visual references and generated data untouched. Cover inherited styles/colors, array tags with row gaps and proof labels at domain boundaries, and document how to reproduce acceptance checks.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d9edc47a02
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #[test] | ||
| fn compound_domains_preserve_inherited_color_in_every_style() { | ||
| let color = Color::new(0.2, 0.4, 0.6, 0.75); | ||
| for style in [MathStyle::Display, MathStyle::Text, MathStyle::Script] { |
There was a problem hiding this comment.
Expand this loop to include the cramped and scriptscript variants. MathStyle has eight variants, but this test exercises only Display, Text, and Script; therefore a refactor that breaks inherited colors specifically for root ScriptScript sizing or any cramped style will still pass despite the test's in_every_style contract.
Useful? React with 👍 / 👎.
1 participant
Add opt-in captures for the main, mhchem and prooftree corpora, comparing complete ASTs, DisplayLists, render results and PNG bytes against a local baseline. Keep committed visual references and generated data untouched.
Cover inherited styles/colors, array tags with row gaps and proof labels at domain boundaries, and document how to reproduce acceptance checks.