test(fix): add CRLF line-ending coverage for name-drift rewrite#22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
fix.tsuses the same\r?\nregex pattern asparse.tsto handle Windows CRLF line endings in skill files.parse.test.tsalready has a CRLF test pinning that behavior, butfix.test.tshas zero CRLF coverage. If the regex inrewriteFrontmatterNameregressed to\n-only, no test would catch it.What
Three new test cases appended to
test/fix.test.ts:applyFixes, confirmsfixed === 1and the new name appears in the rewritten content.\r\nsequences in the body are untouched after the frontmatter rewrite (only the frontmatter delimiters are normalized to LF).fixed === 0, skipped === 1and the file is unchanged when there is noname:key to rewrite.No source changes. Test-only.
Tests
applyFixesvia real tmpdir files, matching the pattern of the existingfix.test.tssuite.Self-merge gate
Generated by Claude Code