feat(mcp): Phase 9 — optional overlay auth preflight - #376
Closed
erishforG wants to merge 1 commit into
Closed
Conversation
Refs #294 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
무엇
MCP tools/call preflight now blocks explicitly requested optional GitHub overlays when no delegated GitHub token is present.
왜
Refs #294. The auth spec says optional PR/CI overlays should be checked before handlers run, instead of silently reaching tool logic without credential context.
변경
worktree_list.include_pr,worktree_list.include_ci, andhealth_check.include_ci.AUTH_REQUIREDresponses.docs/mcp/auth.md.다음 Phase 힌트
Track delegated token scope metadata in
McpContextso preflight can returnINSUFFICIENT_SCOPEwhen a token is present but missing requested scopes.리스크
Low. The change is isolated to
src/mcp/,tests/mcp/, anddocs/mcp/; it only affects explicitly requested GitHub overlays without delegated auth.롤백
Revert the preflight helper and the two fixture records. Existing required-tool auth preflight remains independent.
Test plan
cargo build --quietcargo fmt --checkcargo clippy --all-targets -- -D warningscargo test --quiet@erishforG