feat(mcp): Phase 6 — add stdio ping - #372
Merged
Merged
Conversation
Refs #293 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
무엇
MCP stdio JSON-RPC dispatcher에 lifecycle
ping메서드를 추가합니다.왜
Refs #293. Claude Desktop/Cursor 같은 MCP clients가 transport health check로
ping을 보낼 때 protocol-clean한 빈 object result를 받을 수 있게 합니다. @erishforG변경
src/mcp/mod.rs에서ping메서드를{}result로 응답pingrecording 추가다음 Phase 힌트
tools/callauth context fixture 추가리스크
Low. MCP 전용 dispatcher에 non-mutating lifecycle method를 추가했고 기존 CLI surface와 worktree/git 핵심 로직은 변경하지 않았습니다.
롤백
이 PR revert 시
pingsupport와 fixture/doc 계약만 제거됩니다.Test plan
cargo test --quiet mcp::tests::ping_returns_empty_result_for_client_health_checkscargo test --quiet mcp::tests::stdio_recording_fixtures_match_dispatchercargo build --quietcargo fmt --checkcargo clippy --all-targets -- -D warningscargo test --quiet