Skip to content

Fix search filter not applied and slicer reset on Fetch (#147) #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdarlingdata merged 1 commit into from
Mar 27, 2026
Merged

Fix search filter not applied and slicer reset on Fetch (#147) #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/PlanViewer.App/Controls/QueryStoreGridControl.axaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,9 @@ private async void Fetch_Click(object? sender, RoutedEventArgs e)

try
{
// Load slicer data first — LoadData sets a default 24h selection and
// fires RangeChanged which triggers FetchPlansForRangeAsync.
await LoadTimeSlicerDataAsync(orderBy, ct);
// Load slicer data, preserving the current selection if one exists.
// Without this, LoadData defaults to last 24h and the user's range is lost.
await LoadTimeSlicerDataAsync(orderBy, ct, _slicerStartUtc, _slicerEndUtc);
}
catch (OperationCanceledException)
{
Expand Down Expand Up @@ -195,7 +195,7 @@ private async System.Threading.Tasks.Task FetchPlansForRangeAsync()
try
{
var plans = await QueryStoreService.FetchTopPlansAsync(
_connectionString, topN, orderBy, ct: ct,
_connectionString, topN, orderBy, filter: filter, ct: ct,
startUtc: _slicerStartUtc, endUtc: _slicerEndUtc);

GridLoadingOverlay.IsVisible = false;
Expand Down Expand Up @@ -363,15 +363,17 @@ private void ClearSearch_Click(object? sender, RoutedEventArgs e)
SearchValueBox.Text = "";
}

private async System.Threading.Tasks.Task LoadTimeSlicerDataAsync(string metric, CancellationToken ct)
private async System.Threading.Tasks.Task LoadTimeSlicerDataAsync(
string metric, CancellationToken ct,
DateTime? preserveStart = null, DateTime? preserveEnd = null)
{
try
{
var sliceData = await QueryStoreService.FetchTimeSliceDataAsync(
_connectionString, metric, _slicerDaysBack, ct);
if (ct.IsCancellationRequested) return;
if (sliceData.Count > 0)
TimeRangeSlicer.LoadData(sliceData, metric);
TimeRangeSlicer.LoadData(sliceData, metric, preserveStart, preserveEnd);
else
StatusText.Text = "No time-slicer data available.";
}
Expand Down
Loading