feat: Dismiss Selected in context menu + View Log sidebar button#740
Merged
erikdarlingdata merged 16 commits intoerikdarlingdata:devfrom Mar 27, 2026
Merged
Conversation
- Parse detail_text to extract Database, Query Text, and Wait Type when using 'Mute This Alert' from alert history (both editions) - Add PopulateFromDetailText() to AlertMuteContext for structured field extraction from the label: value format - Add 'Default expiration for new mute rules' dropdown to Settings in both editions (1 hour, 24 hours, 7 days, Never; default 24h) - MuteRuleDialog now selects the configured default expiration instead of always defaulting to 'Never' - Persist setting as mute_rule_default_expiration in settings.json (Lite) and preferences.json (Dashboard) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The XML doc claimed Job Name extraction but the parser did not implement it. Add the missing branch in both Dashboard and Lite editions so the behavior matches the documentation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Collapse newlines in Truncate/TruncateText so detail_text fields stay single-line in the label: value format - Handle multi-line query values in PopulateFromDetailText by accumulating continuation lines until the next indented field - Recognize variant query labels (Blocked Query, Blocking Query, Victim SQL) in addition to Query Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Explain that the field is a case-insensitive substring match and suggest entering a distinctive fragment like a table or procedure name. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Feature/alert muting part 2
Context menu dismiss (both editions): - Added 'Dismiss Selected' menu item with icon to the right-click context menu in Alert History DataGrid - Reuses existing DismissSelected_Click handler no new code needed View Log button (both editions): - Added 'View Log' button to sidebar footer in MainWindow - Opens the current day's log file via ShellExecute; falls back to opening the log directory if the file doesn't exist yet - Lite: exposed GetCurrentLogFile() and GetLogDirectory() on AppLogger - Dashboard: uses existing Logger.GetCurrentLogFile() / GetLogDirectory() Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
While there are currently no conflicts with the base branch, merging in #733 first will require a rebase of this branch with dev. Reply to this so I get a mobile notification that this needs rebasing 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds two small UX improvements to both Dashboard and Lite editions:
Dismiss Selected in context menu — The right-click context menu on the Alert History DataGrid now includes a "Dismiss Selected" option (with ✗ icon), matching the toolbar button. Reuses the existing
DismissSelected_Clickhandler — no new logic needed.View Log button in sidebar — A new "View Log" button in the MainWindow sidebar footer opens the current day's log file via
ShellExecute. If the log file doesn't exist yet, it falls back to opening the log directory. Lite'sAppLoggernow exposesGetCurrentLogFile()andGetLogDirectory()public methods (Dashboard'sLoggeralready had these).Which component(s) does this affect?
How was this tested?
Process.Start+UseShellExecutepattern already used in About dialogsChecklist
dotnet build -c Debug)