fix/numeric columns sorting as text instead of numbers#732
Merged
erikdarlingdata merged 1 commit intoerikdarlingdata:devfrom Mar 27, 2026
Merged
Conversation
DataGrid columns displaying sizes, row counts, durations, and percentages were stored as formatted strings, causing lexicographic sort order (e.g. "9.8" before "87"). Added numeric SortMemberPath companion properties using the same pattern as the existing AutoGrowthSort/VlfCountSort, and wired them up in XAML across both Dashboard and Lite editions. - IndexCleanup summary/detail grids: 22 columns each (Size GB, Rows, etc.) - FinOps recommendations: EstMonthlySavingsDisplay - Query snapshots: Duration, TranLogWrites - Live queries: ElapsedTimeFormatted - Running jobs: CurrentDurationFormatted, AvgDurationFormatted - Deadlock details: WaitTimeFormatted - Running jobs: PercentOfAverageFormatted Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
DataGrid columns displaying sizes, row counts, durations, and percentages were stored as formatted strings, causing lexicographic sort order (e.g. "9.8" before "87"). Added numeric SortMemberPath companion properties using the same pattern as the existing AutoGrowthSort/VlfCountSort, and wired them up in XAML across both Dashboard and Lite editions.
DataGrid columns that display numeric values (sizes, row counts, durations, percentages, costs) were stored as formatted strings, so WPF sorted them lexicographically instead of numerically - e.g., "9.8" sorted before "87.9" because "9" > "8" as a character. This adds numeric companion properties and wires them via SortMemberPath, following the existing AutoGrowthSort / VlfCountSort pattern.
Which component(s) does this affect?
How was this tested?
Checklist
dotnet build -c Debug)