Add bootstrap tab plugin and row selection plugin#1
Open
huer12 wants to merge 1 commit intoericmbarnard:masterfrom
Open
Add bootstrap tab plugin and row selection plugin#1huer12 wants to merge 1 commit intoericmbarnard:masterfrom
huer12 wants to merge 1 commit intoericmbarnard:masterfrom
Conversation
| this._grid = grid; | ||
|
|
||
| this.selectedItems.subscribe(function (newValues) { | ||
| if (_this._grid.$$selectionPhase == true) |
There was a problem hiding this comment.
Suggested change
| if (_this._grid.$$selectionPhase == true) | |
| if (_this._grid.$$selectionPhase === true) |
should be === right
|
|
||
| for (var i = 0; i < _this._grid.rowFactory.rowCache.length; i++) { | ||
| var rowCache = _this._grid.rowFactory.rowCache[i]; | ||
| if (rowCache.entity == newValue) { |
There was a problem hiding this comment.
Suggested change
| if (rowCache.entity == newValue) { | |
| if (rowCache.entity === newValue) { |
should be using ===
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have written two plugins which solve the following issues:
KoGridRowSelectionPlugin.js: Possibility to change the selected items programmatically
koGridBootstrapTabPlugin.js: If the grid is placed within a bootstrap tab, then the layout is not updated correctly without this plugin