Add Dockerfile by gesellix · Pull Request #128 · ericchiang/pup

gesellix · 2020-02-03T20:53:59Z

Adds a Dockerfile, which you might use in automated builds on the Dockerhub.

Relates to #126

SuperSandro2000 · 2020-02-05T18:53:12Z

.dockerignore

@@ -0,0 +1,4 @@
+dist/


You are missing .git

Right. It doesn't have any impact on the final image, though. I'll add a fixup later

SuperSandro2000 · 2020-02-05T18:53:28Z

Dockerfile

@@ -0,0 +1,24 @@
+FROM alpine:3.10 AS builder


Suggested change

FROM alpine:3.10 AS builder

FROM alpine:3.11 AS builder

SuperSandro2000 · 2020-02-05T18:53:49Z

Dockerfile

+FROM alpine:3.10 AS builder
+LABEL builder=true
+
+ENV CGO_ENABLED=0


Suggested change

ENV CGO_ENABLED=0

ENV CGO_ENABLED=0 GOPATH=/go

Do we need this?

It looks nicer and is easier to convert it to an export ....

SuperSandro2000 · 2020-02-05T18:54:58Z

Dockerfile

+ENV CGO_ENABLED=0
+ENV GOPATH /go
+
+RUN apk add --update -t build-deps go git mercurial libc-dev gcc libgcc


Suggested change

RUN apk add --update -t build-deps go git mercurial libc-dev gcc libgcc

RUN apk add --no-cache -t build-deps go git mercurial libc-dev gcc

You don't update base image packages unless it is needed for a reason.
The removed packages are already pulled in with go.

SuperSandro2000 · 2020-02-05T18:55:15Z

Dockerfile

+    -a \
+    -ldflags '-s -w -extldflags "-static"' \
+    -o /bin/pup
+RUN adduser -DH user


this line is useless

It's preparation for the next build step

SuperSandro2000 · 2020-02-05T18:55:40Z

Dockerfile

+
+FROM scratch
+
+ENTRYPOINT [ "/pup" ]


Did it get +x somewhere?

go build handles that one

SuperSandro2000 · 2020-02-05T18:56:04Z

Dockerfile

+ENTRYPOINT [ "/pup" ]
+CMD [ "--help" ]
+
+COPY --from=builder /etc/passwd /etc/passwd


not needed, as you create the user again and the copy can be chowned if needed.

See above, the user is only created in another build step, here we only apply the minimal change to "create" the user. The user itself is not really necessary, but I consider it a best practice not to run everything as root.

If we use FROM scratch we can safely use the root user. There is nothing we can escape to.

"best practice" refers more to "give future users a chance to make things right by default", so yes, FROM scratch minimizes the attack surface, but what happens if anybody wants to convert the image to a Windows container where we don't have an empty base image? Not that I'd do that, but I prefer to keep those minimal baselines and make people become aware of those aspects.

In fact, I don't actually care if the maintainer of pup thinks the same way, so I consider this PR as simple proposal which can have alternate solutions with more focus on simplicity (see your own Dockerfile you already mentioned).

I am pretty sure that a windows variant would have at least 10 more problems cause it is windows and you can't consider everything you might maybe need in the future.

Also this would be a problem for the windows eco system when they only support half of docker.

Yes, you're right and I fully agree. I hope you got my point, though 😉

SuperSandro2000 · 2020-02-05T19:03:20Z

Also when I try to build this I get:

/pup # go get github.com/ericchiang/pup
# github.com/ericchiang/pup
loadinternal: cannot find runtime/cgo

I would suggest using golang:alpine as a base image as this is the only working workaround I could find for that issue.

SuperSandro2000 · 2020-02-05T19:07:45Z

I quickly wrote this Dockerfile which in my opinion is way nicer, smaller and easier to maintain.

FROM golang:alpine as builder

RUN apk add --no-cache git

RUN go get github.com/ericchiang/pup

WORKDIR $GOPATH/src/github.com/ericchiang/pup

RUN go build -a -ldflags '-s -w -extldflags "-static"' -o /bin/pup

#----------#

FROM scratch

COPY --from=builder /bin/pup /pup

ENTRYPOINT [ "/pup" ]
CMD [ "--help" ]

btw the user switch is not needed as the resulting container is basically empty except pup.

matthewadams · 2020-11-09T20:18:53Z

Can y'all get this merged and building automatically on hub.docker.com please?

Add Dockerfile

30287da

gesellix mentioned this pull request Feb 3, 2020

Interest in a Dockerfile? #126

Open

SuperSandro2000 reviewed Feb 5, 2020

View reviewed changes

Dockerfile

@@ -0,0 +1,24 @@

FROM alpine:3.10 AS builder

Copy link

SuperSandro2000 Feb 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

FROM alpine:3.10 AS builder

FROM alpine:3.11 AS builder

SuperSandro2000 reviewed Feb 5, 2020

View reviewed changes

	RUN apk add --update -t build-deps go git mercurial libc-dev gcc libgcc
	RUN apk add --no-cache -t build-deps go git mercurial libc-dev gcc

Conversation

gesellix commented Feb 3, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SuperSandro2000 Feb 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SuperSandro2000 commented Feb 5, 2020

Uh oh!

SuperSandro2000 commented Feb 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthewadams commented Nov 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SuperSandro2000 Feb 5, 2020 •

edited

Loading

SuperSandro2000 commented Feb 5, 2020 •

edited

Loading