Skip to content

ci: repair three-weeks-red main (CODE_MAP drift, fmt, badge) - #84

Merged
sf19-97 merged 3 commits into
mainfrom
ci-green
Jul 11, 2026
Merged

sf19-97 merged 3 commits into
mainfrom
ci-green

Conversation

@sf19-97

@sf19-97 sf19-97 commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

What

Repairs main's CI, red since 2026-06-13 (three weeks). Three commits, four files, 13/12 lines:

  1. CODE_MAP driftcrates/prod/CODE_MAP.md §1 and tools/verify_code_map_drift.sh still referenced ergo-sdk-types, removed from the workspace before first publish (recorded: docs/ledger/decisions/crates-io-publish-set.md, amendment 2026-06-07). Both now reflect the five actual prod crates. The enforcement script edit removes one stale array entry and corrects the expected count; every other check is untouched.
  2. rustfmt — one overlong line in cli/dispatch.rs (from the alpha.2 --version hotfix) wrapped by cargo fmt; fmt-output only.
  3. Visibility — workflow status badge added to README so a red main is never silent for three weeks again.

Verification

  • All five doctrine guard scripts pass (replicated independently on Linux in addition to the implementing machine)
  • cargo fmt --check clean
  • cargo test --workspace: 918 passed, 0 failed, 1 ignored
  • Diffstat: exactly 4 files, 13 insertions, 12 deletions

Audited per AGENT_CONTRACT v1.2 — scope proven exhaustively, no enforcement weakened. This PR run is itself the pre-merge proof: first green workflow since June 13 should appear on these checks.

sf19-97 added 3 commits July 5, 2026 20:52
Align CODE_MAP and the drift guard with docs/ledger/decisions/crates-io-publish-set.md Amendment 2026-06-07, which removed ergo-sdk-types before first publish.
@greptile-apps

greptile-apps Bot commented Jul 11, 2026

Copy link
Copy Markdown

Greptile Summary

This PR repairs three weeks of red CI on main by fixing CODE_MAP drift left over from the removal of ergo-sdk-types, formatting one overlong line in dispatch.rs, and adding a workflow status badge to README.

  • CODE_MAP drift fix: crates/prod/CODE_MAP.md and tools/verify_code_map_drift.sh both still referenced ergo-sdk-types as the sixth prod crate; all three touch-points (table row, prose, count check) are now consistently updated to reflect the five actual crates.
  • rustfmt: One overlong if let expression in dispatch.rs wrapped to satisfy cargo fmt --check; no logic change.
  • Badge: CI badge added to README.md pointing to the correct runtime-surface.yml workflow on main.

Confidence Score: 5/5

Safe to merge — all four files make targeted, mechanical corrections with no production logic changes.

Every change is a precise correction to a stale reference or formatting violation. The CODE_MAP and enforcement script are updated consistently (table row, prose, and count check all agree on five crates). The dispatch.rs diff is a pure formatter wrap with identical semantics. The badge URL resolves to the workflow file that actually exists in the repo. Nothing here touches runtime logic, data handling, or security boundaries.

No files require special attention.

Important Files Changed

Filename Overview
README.md Adds a CI badge pointing to the runtime-surface.yml workflow on main; the workflow file exists and the URL is well-formed.
crates/prod/CODE_MAP.md Removes ergo-sdk-types from the crate inventory table and dependency-chain prose, updates heading and inline count check from six→five; all three touch-points are consistent.
crates/prod/clients/cli/src/cli/dispatch.rs Pure cargo fmt line-wrap of one overlong if let expression; no logic change.
tools/verify_code_map_drift.sh Removes crates/prod/clients/sdk-types from the prod_crates enforcement array and updates the expected count check from 6→5; other checks are untouched and still pass.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[CI red since 2026-06-13] --> B{Root causes}
    B --> C[CODE_MAP still listed ergo-sdk-types as crate 6]
    B --> D[dispatch.rs line too long for rustfmt]
    B --> E[No badge — silent red main]

    C --> F[Update CODE_MAP.md: six → five crates\nRemove ergo-sdk-types row & prose]
    C --> G[Update verify_code_map_drift.sh:\nRemove sdk-types array entry\nCount check 6 → 5]
    D --> H[cargo fmt wraps overlong if-let in dispatch.rs]
    E --> I[Add runtime-surface.yml badge to README]

    F --> J[CI green]
    G --> J
    H --> J
    I --> K[Red main now visible immediately]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[CI red since 2026-06-13] --> B{Root causes}
    B --> C[CODE_MAP still listed ergo-sdk-types as crate 6]
    B --> D[dispatch.rs line too long for rustfmt]
    B --> E[No badge — silent red main]

    C --> F[Update CODE_MAP.md: six → five crates\nRemove ergo-sdk-types row & prose]
    C --> G[Update verify_code_map_drift.sh:\nRemove sdk-types array entry\nCount check 6 → 5]
    D --> H[cargo fmt wraps overlong if-let in dispatch.rs]
    E --> I[Add runtime-surface.yml badge to README]

    F --> J[CI green]
    G --> J
    H --> J
    I --> K[Red main now visible immediately]
Loading

Reviews (1): Last reviewed commit: "docs(readme): add runtime surface ci bad..." | Re-trigger Greptile

@augmentcode

augmentcode Bot commented Jul 11, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Fixes CI regressions by bringing prod CODE_MAP documentation and its drift-enforcement script back in sync with the current set of prod crates.
Changes: Updates crate inventory expectations (6 → 5), applies a rustfmt-only wrap in CLI dispatch, and adds a GitHub Actions status badge to README for visibility.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@sf19-97
sf19-97 merged commit d3d8ae9 into main Jul 11, 2026
3 checks passed
@sf19-97
sf19-97 deleted the ci-green branch July 11, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant