check_swatinit changed tolerance for comparing SWAT and SWATINIT#694
Open
lilbe66 wants to merge 1 commit intoequinor:mainfrom
Open
check_swatinit changed tolerance for comparing SWAT and SWATINIT#694lilbe66 wants to merge 1 commit intoequinor:mainfrom
check_swatinit changed tolerance for comparing SWAT and SWATINIT#694lilbe66 wants to merge 1 commit intoequinor:mainfrom
Conversation
Collaborator
|
Has more examples where issue 347 pops out been found, and has it then been verified that assigning them to PC_SCALED is the correct solution? (I am not taking for granted that the proposal in the issue is correct..) |
Contributor
Author
|
No suitable test case found, so difficult to conclude on the best value for this tolerance. On hold. Discussed with @berland |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #347