Merged
Conversation
Collaborator
LiamPattinson
left a comment
LiamPattinson
left a comment
There was a problem hiding this comment.
Generally all good, just a few stylistic/grammar changes I'd recommend.
Co-authored-by: Liam Pattinson <LiamPattinson@users.noreply.github.com>
Co-authored-by: Liam Pattinson <LiamPattinson@users.noreply.github.com>
Co-authored-by: Liam Pattinson <LiamPattinson@users.noreply.github.com>
Co-authored-by: Liam Pattinson <LiamPattinson@users.noreply.github.com>
Co-authored-by: Liam Pattinson <LiamPattinson@users.noreply.github.com>
Collaborator
Author
|
This does actually pass the docs build https://app.readthedocs.org/projects/sdf-xarray/builds/32171291/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete refactor of several of the doc pages in order to improve clarity and readability. Honestly a bit of a mess to read the changelog but just view the docs online and see what you think.
I've given up on keeping the markdown files to no longer than 80 characters long... Feel that it actually disrupts the flow of writing it