Skip to content

Add kafka config to settings - #27

Merged
elephantum merged 2 commits into
masterfrom
add_kafka_compression
Oct 1, 2026
Merged

elephantum merged 2 commits into
masterfrom
add_kafka_compression

Conversation

@rustam810

Copy link
Copy Markdown

No description provided.

@rustam810
rustam810 requested a review from elephantum October 1, 2026 14:04
@elephantum
elephantum force-pushed the add_kafka_compression branch from 10d900c to 0795c09 Compare October 1, 2026 18:37
@elephantum
elephantum force-pushed the add_kafka_compression branch 2 times, most recently from e42c7ba to 3a61cb4 Compare October 1, 2026 19:01
`[input.config]` / `[output.config]` set any librdkafka property on the
consumer or producer, merged over the ones derived from the typed fields.
Compression is the first user: `"compression.type" = "zstd"`.

The properties tkati sets itself are rejected at settings-parse time rather
than merged over. librdkafka accepts `enable.auto.commit=true` silently, and
the consumer's explicit-commit protocol depends on it being false.

No defaults changed. Design: design-docs/2026-10-01-kafka-config-passthrough.md
Partly addresses F5 in design-docs/2026-09-27-tkati-core-audit.md.

design doc: Kafka client config passthrough
@elephantum elephantum changed the title add kafka compression Add kafka config to settings Oct 1, 2026
@elephantum
elephantum force-pushed the add_kafka_compression branch from 3a61cb4 to 65fcc51 Compare October 1, 2026 19:20
@elephantum
elephantum merged commit eb7a3e5 into master Oct 1, 2026
8 checks passed
@elephantum
elephantum deleted the add_kafka_compression branch October 1, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants