Fix the paper plane's nose and trail, and the step overlap at tablet widths - #99
Merged
Merged
Conversation
Re-extract the plane from the design with a wider region, keeping only the plane's connected pixels so the nose is intact and no trail dashes come along. The trail now ends where it meets the tail's edge, on the same straight run as the last dashes, instead of hooking down to the tip. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
kentcdodds
marked this pull request as ready for review
September 14, 2026 21:43
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| * run as the last few dashes, so the two always meet without a kink. | ||
| */ | ||
| const PLANE = { x: 1009, y: 136, width: 117, height: 93 } | ||
| const PLANE = { x: 1009, y: 135, width: 158, height: 102 } |
There was a problem hiding this comment.
Plane box height mismatches asset
Medium Severity
PLANE is sized 158×102, but paper-plane.png is 158×119. The SVG image letterboxes that taller asset in the shorter box, so the plane renders narrower than the design and the trail no longer meets the tail.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit e6861b4. Configure here.
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
1 issue from previous review remains unresolved.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e6861b4. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #98 for three landing-page issues in the "How it works" section.
paper-plane.pnghad been extracted from a region that cut off the nose. It is re-extracted from the design with a wider region, keeping only the plane's connected pixels so no trail dashes ride along. The<image>box is updated to the new 158×102 size at the same design position.-mt-[7.75rem]) applied frommd, but the extra top margin that makes room for it (and the trail itself) only apply fromlg. The stagger is nowlg-only.Test Plan
bun run typecheck,bun run lintpass; 14 Playwright e2e tests pass.Checklist
Screenshots