Stop reporting React Router method errors to Sentry - #96
Merged
Merged
Conversation
Server handleError was capturing RouteErrorResponses for bot OPTIONS, GraphQL probe POSTs, and GETs to action-only resource routes. Skip those (matching the client ErrorBoundary), add a beforeSend safety net, and give splat/theme-switch handlers for the common probe paths. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
kody-bot
marked this pull request as ready for review
July 24, 2026 20:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the three open
getInternalRouterErrorSentry issues ingratitext(GRATITEXT-J / M / K). Event inspection showed they are not one app bug: scanners POSTing GraphQL probe paths, OPTIONS preflights, and GETs to the action-only theme-switch resource. ServerhandleErrorwas capturing thoseRouteErrorResponses even though the clientGeneralErrorBoundaryalready ignores them.Changes
RouteErrorResponseinhandleErrorviashouldReportToSentrybeforeSendfilter for React Router method-noise messages (defense in depth)actionreturns 404 (same as loader) for probe POSTsloaderredirects home for bare GETsSentry outcomes
7242579523) — fixed → resolved7281219877) — fixed → resolved7251829085) — fixed → resolvedStatus
mainTest Plan
bun test(includes newerror-reporting.server.test.ts)bun run lintbun run typecheckmainChecklist
Screenshots
N/A (server-side Sentry reporting / route method handling)