Redirect gratitext.app to www.gratitext.app - #100
Merged
Merged
Conversation
gratitext.app now resolves to the app too, but session cookies are host-scoped and search engines should see one origin, so 301 it to www.gratitext.app in the same middleware that forces HTTPS. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 8865b73. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The apex domain now has DNS records and a Fly certificate (added via Kody earlier today), so the app serves on both
gratitext.appandwww.gratitext.app. Session cookies are host-scoped and search engines should see a single origin, so this 301s the apex towwwin the same Express middleware that already forces HTTPS. Other hosts (localhost,gratitext.fly.dev) are untouched.Test Plan
bun run typecheck,bun run lintpass.Host: gratitext.app/login?redirectTo=%2Frecipients→301 https://www.gratitext.app/login?redirectTo=%2FrecipientsHost: gratitext.app+X-Forwarded-Proto: http→301 https://www.gratitext.app/(one hop, not two)Host: www.gratitext.app+X-Forwarded-Proto: http→302 https://www.gratitext.app/(existing behaviour)localhost→200Checklist